fix findings of detekt

[tobiasKaminsky]

Detekt is now at 0 💪

Signed-off-by: tobiasKaminsky [email protected]

[github-actions]

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

[codecov]

Codecov Report

Merging #1027 (16027d9) into master (93812ac) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

❗ Current head 16027d9 differs from pull request most recent head ac81c09. Consider uploading reports for the commit ac81c09 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
- Coverage   49.42%   49.27%   -0.15%     
==========================================
  Files         179      179              
  Lines        6727     6725       -2     
  Branches      894      892       -2     
==========================================
- Hits         3325     3314      -11     
- Misses       2935     2942       +7     
- Partials      467      469       +2     

Impacted Files	Coverage Δ
.../main/java/com/nextcloud/common/NextcloudClient.kt	58.82% <0.00%> (+1.68%)	⬆️
...wncloud/android/lib/resources/files/FileUtils.java	71.42% <0.00%> (-14.29%)	⬇️
...b/resources/files/CreateFolderRemoteOperation.java	70.58% <0.00%> (-8.83%)	⬇️
...d/lib/common/operations/RemoteOperationResult.java	45.82% <0.00%> (-1.16%)	⬇️
...om/owncloud/android/lib/common/OwnCloudClient.java	42.85% <0.00%> (-1.15%)	⬇️

[github-actions]

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

[github-actions]

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

[github-actions]

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

[github-actions]

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

[nextcloud-android-bot]

master-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1583-IT-master-12-29