Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

add sample test

Signed-off-by: tobiasKaminsky [email protected]

@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

AlvaroBrey
AlvaroBrey previously approved these changes Dec 13, 2022
add sample test

Signed-off-by: tobiasKaminsky <[email protected]>
@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@tobiasKaminsky
Copy link
Member Author

**Detect new java files / detectNewJavaFiles (pull_request) ** Failing after 3s

Sample client project is still Java only, so I did not want to change it within this PR.

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #1010 (d81e6bd) into master (2550afb) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1010      +/-   ##
==========================================
+ Coverage   48.95%   49.17%   +0.21%     
==========================================
  Files         178      178              
  Lines        6686     6687       +1     
  Branches      886      886              
==========================================
+ Hits         3273     3288      +15     
+ Misses       2941     2929      -12     
+ Partials      472      470       -2     
Impacted Files Coverage Δ
...wncloud/android/lib/resources/shares/ShareeUser.kt 100.00% <100.00%> (ø)
...d/android/lib/resources/status/NextcloudVersion.kt 100.00% <100.00%> (ø)
...sources/status/GetCapabilitiesRemoteOperation.java 50.00% <0.00%> (+0.33%) ⬆️
...ncloud/android/lib/common/network/WebdavEntry.java 79.28% <0.00%> (+0.39%) ⬆️
...om/owncloud/android/lib/common/OwnCloudClient.java 44.00% <0.00%> (+1.14%) ⬆️
...d/lib/common/operations/RemoteOperationResult.java 46.97% <0.00%> (+1.15%) ⬆️
.../lib/resources/files/CheckEtagRemoteOperation.java 85.71% <0.00%> (+10.71%) ⬆️
...lib/resources/files/RemoveFileRemoteOperation.java 88.88% <0.00%> (+16.66%) ⬆️

@tobiasKaminsky tobiasKaminsky merged commit be24e92 into master Dec 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the readme branch December 15, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants