add debug output and missing exception handlers to fix #459 #460
Conversation
|
How does logException fixes something? Mind to share |
|
Hi @kesselb , sorry, I switched the lines, I think the actual fix is below, in line 415. 410 of course only helps in regard of debugging ;-) |
Signed-off-by: Markus Schlichting <[email protected]>
madmas
force-pushed
the
endlessNotificationsFix
branch
from
e85a42f
to
19e481f
Compare
|
Mind to share the exception? Also you overwrite the actual exception message. That makes it harder to debug. |
| @@ -405,6 +407,12 @@ protected function sendEmailToUser($userName, $email, $lang, $timezone, $maxTime | |||
| try { | |||
| $this->mailer->send($message); | |||
| } catch (\Exception $e) { | |||
| $this->logger->logException($e, [ | |||
| 'message' => 'Failed sending email to user "{user}"', | |||
| 'user' => $user, | |||
There was a problem hiding this comment.
Log the exception with $this->logger->logException($e); and log a additional warning $this->logger->warning('Failed to send notification email for user {user}', ['user' => $userName]);. You cannot use Ah that might work as the normalizer will format it. I would still prefer the $userName ;)$user because it's a IUser object.
change the glue for implode from | to , Co-authored-by: kesselb <[email protected]>
My experience was vice versa - with the output I added with shown here, I got much more details. |
|
We still don't know why sending the notification failed in the first place. This is fixing symptoms not problems 😟 |
add debug outout and exception handling fix to get rid of over-and-over sent notifications.
I think esp. the changes to line 410 helped to fix the issue.