feat: migrate to esbuild via esbuild-loader #657
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
changed the title
ShGKme
reviewed
Apr 4, 2025
Collaborator
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
If there is no tsconfig.json in the app using this config, ESBuild will search for it. And for apps cloned to the server/apps, it will find server's tsconfig.
| */ | ||
|
|
||
| module.exports = { | ||
| const esbuildTarget = 'es2015' |
Collaborator
There was a problem hiding this comment.
Suggested change
| const esbuildTarget = 'es2015' | |
| const esbuildTarget = 'es2020' |
Or even newer.
Comment on lines
+50
to
+52
| options: { | ||
| target: esbuildTarget, | ||
| }, |
Collaborator
There was a problem hiding this comment.
Suggested change
| options: { | |
| target: esbuildTarget, | |
| }, | |
| options: { | |
| loader: 'ts', // Fix loading Vue SFCs | |
| target: esbuildTarget, | |
| }, |
| }, | ||
| extractComments: true, | ||
| }), | ||
| new EsbuildPlugin(), |
Collaborator
There was a problem hiding this comment.
Suggested change
| new EsbuildPlugin(), | |
| new EsbuildPlugin({ | |
| target: 'es2020' | |
| }), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #600
Migrate from Babel + Terser (+ ts-loader) to just esbuild via esbuild-loader.