Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export config depending on environment #10

Merged
merged 1 commit into from
Jul 13, 2020
Merged

export config depending on environment #10

merged 1 commit into from
Jul 13, 2020

Conversation

korelstar
Copy link
Contributor

This moves the dev/prod switch from app to lib. The code needed in apps is reduced even more.

This is an alternative approach to PR #9

@korelstar korelstar requested a review from skjnldsv July 13, 2020 08:15
@korelstar korelstar mentioned this pull request Jul 13, 2020
Closed
skjnldsv
skjnldsv approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure :)

@korelstar korelstar merged commit aa13899 into master Jul 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the switch-config branch July 13, 2020 08:57
@korelstar
Copy link
Contributor Author

@skjnldsv A further optimization would be to move the check to webpack.common.js. Then we could drop webpack.dev.js, webpack.prod.js, and the webpack-merge (peer) dependency.

What do you think of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korelstar @skjnldsv