-
Notifications
You must be signed in to change notification settings - Fork 95
feat(NcUserStatusIcon): update status icons #7218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
|
/backport to stable8 |
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good
|
Another question - do we trying to scope it for v32? |
jancborchardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Until we say that nextcloud-vue@8 is not compatible with the current nextcloud/server, we should backport. But it shouldn't be a problem, at it only adds support for a new value, so it doesn't do anythign with servers without Busy status support, do it? |
Nope, but general appearance of icons will change, as soon as someone bumps a library. Then users might be surprised to see new 'Online' and 'Away' icons |
I do not think this is really a big issue - so I would just backport and use as is. |
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicable