Skip to content

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 29, 2025

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image
2025-07-29_14h29_29 2025-07-29_14h29_54 image image

🚧 Tasks

  • In-app screenshots

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@Antreesy Antreesy self-assigned this Jul 29, 2025
@Antreesy Antreesy added 3. to review Waiting for reviews design Design, UX, interface and interaction design labels Jul 29, 2025
@Antreesy
Copy link
Contributor Author

/backport to stable8

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@Antreesy
Copy link
Contributor Author

Another question - do we trying to scope it for v32?
Asking as it should end up on server, and thus would require backport to stable8 branch

Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ShGKme
Copy link
Contributor

ShGKme commented Jul 29, 2025

Another question - do we trying to scope it for v32?
Asking as it should end up on server, and thus would require backport to stable8 branch

Until we say that nextcloud-vue@8 is not compatible with the current nextcloud/server, we should backport.

But it shouldn't be a problem, at it only adds support for a new value, so it doesn't do anythign with servers without Busy status support, do it?

@Antreesy
Copy link
Contributor Author

so it doesn't do anything with servers without Busy status support

Nope, but general appearance of icons will change, as soon as someone bumps a library. Then users might be surprised to see new 'Online' and 'Away' icons

@susnux
Copy link
Contributor

susnux commented Jul 29, 2025

Nope, but general appearance of icons will change, as soon as someone bumps a library. Then users might be surprised to see new 'Online' and 'Away' icons

I do not think this is really a big issue - so I would just backport and use as is.

@Antreesy Antreesy merged commit 8f9e44a into main Jul 29, 2025
25 checks passed
@Antreesy Antreesy deleted the feat/15465/user-status-icons branch July 29, 2025 18:19
@Antreesy Antreesy mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UX, interface and interaction design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants