fix(NcActions): check slot content only during the rendering #5197
+114
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- $scopedSlots cannot be used in beforeUpdated. On re-rendering, when vnode is reused, on beforeUpdated $scopedSlots returns an old value and breaks rendering. - Officially, $slots/$scopedSlots should be used only during the rendering - This commit returns $slots to have an old behavior and resolve regression - TODO: find better soluton to support both slots API Reverts commit b94ff04 Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
2 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5197 +/- ##
==========================================
+ Coverage 39.34% 39.39% +0.04%
==========================================
Files 139 139
Lines 3688 3691 +3
Branches 810 810
==========================================
+ Hits 1451 1454 +3
Misses 2021 2021
Partials 216 216 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
🏁 Checklist