Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcSelect): remove visual gap on top of the list #5095

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix(NcSelect): remove visual gap on top of the list #5095

merged 1 commit into from
Jan 18, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 18, 2024

☑️ Resolves

outline shows a border on all the sides, including the top, which looks like a gap.

Using box-shadow allows adding outline only on 3 sides, except the top.

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: select Related to the NcSelect* components labels Jan 18, 2024
@ShGKme ShGKme added this to the 8.5.0 milestone Jan 18, 2024
@ShGKme ShGKme self-assigned this Jan 18, 2024
@ShGKme ShGKme force-pushed the fix/nc-select--annoying-gap branch from 2875c01 to ed467df Compare January 18, 2024 21:03
@ShGKme
Copy link
Contributor Author

ShGKme commented Jan 18, 2024

This annoyed me every day 🙈

raimund-schluessler
raimund-schluessler requested changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I wasn't aware that box-shadow could be used for this 👍

But it needs a minor adjustment to work properly when the select opens to the top, see here:
image

@ShGKme ShGKme force-pushed the fix/nc-select--annoying-gap branch from ed467df to 1819981 Compare January 18, 2024 21:53
@ShGKme
Copy link
Contributor Author

ShGKme commented Jan 18, 2024

@raimund-schluessler thanks!

Pytal
Pytal approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯 available since Chrome 10!

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 18, 2024
@Pytal Pytal merged commit 6e59fab into master Jan 18, 2024
15 checks passed
@Pytal Pytal deleted the fix/nc-select--annoying-gap branch January 18, 2024 23:08
@Pytal Pytal mentioned this pull request Jan 23, 2024
Merged
@dartcafe dartcafe mentioned this pull request Jan 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@susnux susnux Awaiting requested review from susnux

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees

@ShGKme ShGKme

Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feature: select Related to the NcSelect* components
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.

[NcSelect] Minor presentation issue
3 participants
@ShGKme @raimund-schluessler @Pytal