Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NcDialog): add navigationAriaLabel and navigationAriaLabelledBy props #5083

Merged
merged 2 commits into from
Jan 19, 2024
Merged

feat(NcDialog): add navigationAriaLabel and navigationAriaLabelledBy props #5083

merged 2 commits into from
Jan 19, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 17, 2024 •
edited
Loading

☑️ Resolves

Allows labeling navigation in dialogs when the name doesn't work well as a navigation label.

For example, "Select location for attachments" doesn't work well as a navigation for "All files", "Recent", Favorites".

image

Also, updated labeling in NcAppSettingsDialog using this new prop

Before After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@ShGKme ShGKme added enhancement New feature or request 2. developing Work in progress feature: dialog Related to the dialog component accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Jan 17, 2024
@ShGKme ShGKme self-assigned this Jan 17, 2024
@ShGKme ShGKme force-pushed the feat/nc-dialog--aria-label-nav branch from 4576ff5 to 3655d48 Compare January 17, 2024 20:06
@ShGKme ShGKme force-pushed the feat/nc-dialog--aria-label-nav branch from 3655d48 to 08d0a89 Compare January 18, 2024 18:56
@ShGKme ShGKme added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 18, 2024
@ShGKme ShGKme added this to the 8.5.0 milestone Jan 18, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Jan 18, 2024

Updated NcAppSettingsDialog using new pros (see PR description for an example)

@ShGKme ShGKme marked this pull request as ready for review January 18, 2024 19:01
@ShGKme ShGKme force-pushed the feat/nc-dialog--aria-label-nav branch from 08d0a89 to d4bcfc4 Compare January 19, 2024 20:13
@ShGKme
Copy link
Contributor Author

ShGKme commented Jan 19, 2024

Resolved conflict, no changes.

@ShGKme ShGKme enabled auto-merge January 19, 2024 20:13
@ShGKme ShGKme merged commit 710c852 into master Jan 19, 2024
15 checks passed
@ShGKme ShGKme deleted the feat/nc-dialog--aria-label-nav branch January 19, 2024 20:15
@Pytal Pytal mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@susnux susnux susnux approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request feature: dialog Related to the dialog component
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ShGKme @susnux @JuliaKirschenheuter @Pytal