Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcAppNavigation): remove background square connecting toggle and navigation #4779

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 8, 2023

☑️ Resolves

See: #4767 (comment)

Returns transparency between the app navigation and the toggle. Only the toggle button has a background.

Before (no text between nav and toggle) After (text is visible, only toggle has background)
image image

@ShGKme ShGKme self-assigned this Nov 8, 2023
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Btw, unrelated but the left navigation could use a border-right to separate for narrow screens. On desktop itnis separated by the glass-look, but on mobile there is no separation between the backgrounds.

@susnux susnux merged commit 1d9c73a into master Nov 8, 2023
@susnux susnux deleted the fix/app-navigation--small-screen-2 branch November 8, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants