-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix height of label
and input
on NcInputField
#4629
Conversation
Signed-off-by: julia.kirschenheuter <[email protected]>
What is the difference between |
truncated text |
Why is the text clipped at the bottom? Also the input and the placeholder text is placed not where it should be (not related to the PR but seen on the screenshots. Something wrong is going on there). |
The increased height now causes this visual bug where the background overflows the bottom border for a short moment: vokoscreenNG-2023-10-10_11-27-17.mp4 |
@JuliaKirschenheuter Your branch is quite a bit behind But nonetheless, I can confirm the problem. It also occurs in the styleguide. It happens because this rule
is overwritte by this rule
|
Thank you @raimund-schluessler and @susnux! @susnux would you have some suggestions how to fix initial problem? |
@susnux do we have any feedback from designers? How could we move forwards? |
@JuliaKirschenheuter @susnux I am not sure where design input is needed here? The bug seems to be merely CSS where the text is somehow set to overflow: none (or something similar). There should be no heightening of the input, but only fixing of the cutoff and/or white container size. |
@jancborchardt it is about #4582 As that solution would fix this here without any adjustments. Meaning a design team decision on that issue (as requested by Marco) |
issue was solved here: #4718 |
☑️ Resolves
Fix height for text spacing requirements. Checked with ARCToolkit.
🖼️ Screenshots
🏁 Checklist