Add Nc prefix to all components #3058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
force-pushed
the
fix/2643/component-names
branch
from
e7bd14f to
bbab76a
Compare
raimund-schluessler
added
2. developing
raimund-schluessler
force-pushed
the
fix/2643/component-names
branch
5 times, most recently
from
03dc636 to
5e46fce
Compare
raimund-schluessler
added
3. to review
raimund-schluessler
requested review from
ChristophWurst,
GretaD,
PVince81,
jotoeri,
marcoambrosini,
nickvergessen,
skjnldsv,
st3iny,
tcitworld and
vinicius73
skjnldsv
approved these changes
Aug 18, 2022
nickvergessen
approved these changes
Aug 18, 2022
Contributor
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
There's an elephant in my room
Contributor
|
Conflicts! |
Contributor
|
We should stop merging stuff until this is in. Conflict caused by a one liner |
vinicius73
approved these changes
Aug 18, 2022
Merged
raimund-schluessler
force-pushed
the
fix/2643/component-names
branch
from
5e46fce to
87b145b
Compare
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
fix/2643/component-names
branch
from
87b145b to
8705a05
Compare
Contributor
Author
|
Rebased. |
skjnldsv
added
4. to release
This was referenced Aug 18, 2022
Oliv4945
added a commit
to Oliv4945/ldapcontacts
that referenced
this pull request
May 15, 2023
So renamed all Nextcloud component with NC prefix, see [here](nextcloud-libraries/nextcloud-vue#3058)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
Ncprefix to all component names to be in line with eslint and consistent for all components.This was not a fun thing to do, and won't be when migrating apps 🙈
Closes #2643, supersedes #3050