Add title section to settingsdialog #2719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoambrosini
added
enhancement
skjnldsv
force-pushed
the
feature/1709/add-title-to-settings-dialog
branch
from
cdac1bb to
42e3c4e
Compare
marcoambrosini
force-pushed
the
feature/1709/add-title-to-settings-dialog
branch
3 times, most recently
from
d131e52 to
ece6e1b
Compare
Signed-off-by: John Molakvoæ <[email protected]>
this will scroll into view the element with some whitespace on top upon cliching a navigation entry Signed-off-by: Marco Ambrosini <[email protected]>
marcoambrosini
force-pushed
the
feature/1709/add-title-to-settings-dialog
branch
from
c7eb826 to
f1480a9
Compare
marcoambrosini
added
3. to review
GretaD
approved these changes
Jun 2, 2022
Contributor
GretaD
left a comment
GretaD
left a comment
There was a problem hiding this comment.
code looks good, didnt test it
skjnldsv
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..Also gets rid of the annoying title without top margin when scrolling into view
Screen.Recording.2022-06-02.at.16.05.09.mov
Signed-off-by: Marco Ambrosini [email protected]