Skip to content

Commit

Permalink
Fix eslint errors
Browse files Browse the repository at this point in the history
Signed-off-by: Raimund Schlüßler <[email protected]>
  • Loading branch information
raimund-schluessler committed Dec 12, 2022
1 parent 1c59480 commit d11c189
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 7 deletions.
1 change: 1 addition & 0 deletions src/components/NcBreadcrumb/NcBreadcrumb.vue
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ export default {
}
/**
* Event emitted when something is dropped on the breadcrumb.
*
* @param {Event} event The DOM drop event
* @param {(string|object)} to The `to` prop or, if not set, the `href` prop
*/
Expand Down
2 changes: 1 addition & 1 deletion src/components/NcGuestContent/NcGuestContent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export default {
mounted() {
document.getElementById('content').classList.add('nc-guest-content')
},
destroyed() {
unmounted() {
document.getElementById('content').classList.remove('nc-guest-content')
},
}
Expand Down
4 changes: 3 additions & 1 deletion src/components/NcHeaderMenu/NcHeaderMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,9 @@ export default {

emits: [
'close',
'closed',
'open',
'opened',
'update:open',
'cancel',
],
Expand Down Expand Up @@ -173,7 +175,7 @@ export default {
mounted() {
document.addEventListener('keydown', this.onKeyDown)
},
beforeDestroy() {
beforeUnmount() {
document.removeEventListener('keydown', this.onKeyDown)
},

Expand Down
1 change: 1 addition & 0 deletions src/components/NcPopover/NcPopover.vue
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ export default {
setReturnFocus: {
required: false,
type: Object,
default: false,
},
},

Expand Down
4 changes: 2 additions & 2 deletions src/components/NcSelect/NcSelect.vue
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,6 @@ export default {
'select--no-wrap': noWrap,
}"
v-bind="propsToForward"
v-on="$listeners"
@search="searchString => search = searchString">
<template #open-indicator="{ attributes }">
<ChevronDown v-bind="attributes"
Expand Down Expand Up @@ -504,7 +503,7 @@ export default {
<template #no-options>
{{ t('No results') }}
</template>
<template v-for="(_, name) in $scopedSlots" #[name]="data">
<template v-for="(_, name) in $slots" #[name]="data">
<!-- @slot Any combination of slots from https://vue-select.org/api/slots.html -->
<slot :name="name" v-bind="data" />
</template>
Expand Down Expand Up @@ -769,6 +768,7 @@ export default {

const propsToForward = {
...initialPropsToForward,
...this.$attrs,
label: this.localLabel,
}

Expand Down
6 changes: 3 additions & 3 deletions src/components/NcSelectTags/NcSelectTags.vue
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export default {
:value="localValue"
@search="searchString => search = searchString"
@input="handleInput"
v-on="{ ...$listeners, input: () => {} }">
v-on="{ input: () => {} }">
<!-- Do not forward input event listener to NcSelect as we emit custom input events programmatically -->
<template #option="option">
<NcEllipsisedOption :name="getOptionLabel(option)"
Expand All @@ -147,7 +147,7 @@ export default {
<NcEllipsisedOption :name="getOptionLabel(selectedOption)"
:search="search" />
</template>
<template v-for="(_, name) in $scopedSlots" #[name]="data">
<template v-for="(_, name) in $slots" #[name]="data">
<!-- @slot Any combination of slots from https://vue-select.org/api/slots.html -->
<slot :name="name" v-bind="data" />
</template>
Expand Down Expand Up @@ -286,7 +286,7 @@ export default {
...propsToForward
} = this.$props

return propsToForward
return { propsToForward, ...this.$attrs }
},
},

Expand Down

0 comments on commit d11c189

Please sign in to comment.