Skip to content

Commit

Permalink
fixup! Remove unneeded tab, tablist and aria-selected roles fro…
Browse files Browse the repository at this point in the history
…m navigation

Signed-off-by: julia.kirschenheuter <[email protected]>
  • Loading branch information
JuliaKirschenheuter committed Jan 18, 2024
1 parent a4ff840 commit b178c78
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/components/NcAppSettingsDialog/NcAppSettingsDialog.vue
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,15 @@ export default {
<ul v-if="!isCollapsed"
class="navigation-list">
<li v-for="section in sections" :key="section.id">
<a :aria-current="section.id === selectedSection"
<a :aria-current="`${section.id === selectedSection}`"
:class="{
'navigation-list__link': true,
'navigation-list__link--active': section.id === selectedSection,
'navigation-list__link--icon': hasNavigationIcons,
}"
:href="`#${section.id}`"
:href="`#settings-section_${section.id}`"
tabindex="0"
@click="handleSettingsNavigationClick(section.id)"
@click.prevent="handleSettingsNavigationClick(section.id)"
@keydown.enter="handleSettingsNavigationClick(section.id)">
<div v-if="hasNavigationIcons" class="navigation-list__link-icon">
<NcVNodes v-if="section.icon" :vnodes="section.icon" />
Expand Down

0 comments on commit b178c78

Please sign in to comment.