-
Notifications
You must be signed in to change notification settings - Fork 2
fix: use correct path for watch parameter #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Christian Hartmann <[email protected]>
|
/backport to stable1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both paths seem correct
https://rollupjs.org/configuration-options/#watch-allowinputinsideoutputpath
Probably Vite overrides the one from rollupOptions?
Thats also my guess |
|
It seems it then always tries to use watch mode even if |
|
Oh ok, I didn't test that, just tried if the watch parameter works again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See vitejs/vite#20657 (comment)
We need to either detect this with the suggested work around or investigate why rollupOptions are not working here - as locally it works (without this library).
|
This is a vite bug: vitejs/vite#20674 |
Ok, so we can close this one and wait for the upstream fix? |
|
Will be fixed with #693 |
This replaces a PR for Forms (nextcloud/forms#2872) that fixes nextcloud/forms#2869
In #666 the rollup config was adjusted but used a wrong path for the introduced parameter.