Skip to content

Conversation

@Chartman123
Copy link

This replaces a PR for Forms (nextcloud/forms#2872) that fixes nextcloud/forms#2869

In #666 the rollup config was adjusted but used a wrong path for the introduced parameter.

@susnux susnux requested review from ShGKme and susnux August 19, 2025 14:54
@susnux susnux added type: bug 🐛 Something isn't working 3. to review 3️⃣ Waiting for reviews labels Aug 19, 2025
@susnux
Copy link
Contributor

susnux commented Aug 19, 2025

/backport to stable1

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both paths seem correct
https://rollupjs.org/configuration-options/#watch-allowinputinsideoutputpath

Probably Vite overrides the one from rollupOptions?

@susnux
Copy link
Contributor

susnux commented Aug 19, 2025

Probably Vite overrides the one from rollupOptions?

Thats also my guess

@susnux
Copy link
Contributor

susnux commented Aug 19, 2025

It seems it then always tries to use watch mode even if --watch was not specified

@Chartman123
Copy link
Author

Oh ok, I didn't test that, just tried if the watch parameter works again

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See vitejs/vite#20657 (comment)

We need to either detect this with the suggested work around or investigate why rollupOptions are not working here - as locally it works (without this library).

@susnux
Copy link
Contributor

susnux commented Aug 24, 2025

This is a vite bug: vitejs/vite#20674

@Chartman123
Copy link
Author

This is a vite bug: vitejs/vite#20674

Ok, so we can close this one and wait for the upstream fix?

@susnux
Copy link
Contributor

susnux commented Sep 1, 2025

Will be fixed with #693

@susnux susnux closed this Sep 1, 2025
@Chartman123 Chartman123 deleted the fix/watch branch September 1, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review 3️⃣ Waiting for reviews backport-request type: bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm run dev:watch not works

3 participants