fix: Avoid inputs to be subpaths of output #630
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
type: bug
artonge
force-pushed
the
artonge/fix_input_subpaths_of_output
branch
from
c180be3 to
76afcd1
Compare
This will be an issue as of rollup v5.40.2: rollup/rollup#5956 This also remove the warning mentioned here: #171 Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix_input_subpaths_of_output
branch
from
76afcd1 to
d35b9d0
Compare
artonge
added
3. to review
artonge
added a commit
to nextcloud/activity
that referenced
this pull request
Jun 2, 2025
Once nextcloud-libraries/nextcloud-vite-config#630 is in Signed-off-by: Louis Chemineau <[email protected]>
2 tasks
artonge
added a commit
to nextcloud/activity
that referenced
this pull request
Jun 2, 2025
Once nextcloud-libraries/nextcloud-vite-config#630 is in Signed-off-by: Louis Chemineau <[email protected]>
susnux
reviewed
Jun 3, 2025
| // Output dir is the project root to allow main style to be generated within `/css` | ||
| outDir: '', | ||
| outDir: 'js', | ||
| assetsDir: '../', |
Contributor
There was a problem hiding this comment.
Does not work assets are still put into js.
E.g. when using this on the first run wizard it creates:
js/css/firstrunwizard-style.css
Contributor
Author
There was a problem hiding this comment.
Weird, it is working with activity. I'll try to reproduce
Contributor
Author
There was a problem hiding this comment.
Indeed, I could reproduce.
For posterity, I tried setting a relative path ../css/[...] in assetFilesName, but vite does not like relative paths in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.