fix(lib): Include hash in assets name #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using css inlining and multiple output formats (e.g. esm and cjs) the assets order is not deterministic. This causes issues if the assets are named the same, e.g. if you have multiple "index" entry points the assets will be called index1, index2... So when not using hashes the last output format might override the assets with a changed order, causing the previous output formats to be invalid. Signed-off-by: Ferdinand Thiessen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using css inlining and multiple output formats (e.g. esm and cjs) the assets order is not deterministic. This causes issues if the assets are named the same, e.g. if you have multiple "index" entry points the assets will be called index1, index2... So when not using hashes the last output format might override the assets with a changed order, causing the previous output formats to be invalid.