fix(UploadPicker): Add label for upload progress and connect progress with description [a11y] #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
JuliaKirschenheuter,
skjnldsv,
Pytal and
ShGKme
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1000 +/- ##
=======================================
Coverage 92.10% 92.10%
=======================================
Files 3 3
Lines 76 76
Branches 13 13
=======================================
Hits 70 70
Misses 3 3
Partials 3 3 ☔ View full report in Codecov by Sentry. |
ShGKme
approved these changes
Dec 14, 2023
… with description Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/invalid-form
branch
from
8aa84d0 to
144c40d
Compare
Pytal
approved these changes
Dec 14, 2023
This was referenced Dec 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
progresselement #1001All form elements - and this includes also the
progresselement - need a label this is now added.Also semantically connecting the description with the progress by using
aria-describedby