test cy.runCommand and cy.runOccCommand #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
force-pushed
the
test/docker-commands
branch
from
97ecee8 to
22ef885
Compare
max-nextcloud
commented
Jan 8, 2025
cypress/e2e/occ.cy.ts
Outdated
Comment on lines
8
to
9
| cy.runOccCommand('app:list').then(output => { | ||
| expect(output.stdout).to.contain('viewer') |
There was a problem hiding this comment.
Funny... passes locally for me but fails on CI because the app list does not include viewer.
Cotent of output.stdout in the failed test
Enabled:
- cloud_federation_api: 1.14.0
- comments: 1.21.0
- contactsinteraction: 1.12.0
- dashboard: 7.11.0
- dav: 1.32.0
- federatedfilesharing: 1.21.0
- federation: 1.21.0
- files: 2.3.0
- files_reminders: 1.4.0
- files_sharing: 1.23.0
- files_trashbin: 1.21.0
- files_versions: 1.24.0
- lookup_server_connector: 1.19.0
- oauth2: 1.19.0
- provisioning_api: 1.21.0
- settings: 1.14.0
- sharebymail: 1.21.0
- systemtags: 1.21.0
- theming: 2.6.0
- twofactor_backupcodes: 1.20.0
- updatenotification: 1.21.0
- user_status: 1.11.0
- weather_status: 1.11.0
- workflowengine: 2.13.0
Disabled:
- admin_audit: 1.21.0
- encryption: 2.19.0
- files_external: 1.23.0
- testing: 1.21.0
- user_ldap: 1.22.0
- webhook_listeners: 1.2.0'
Looks like something does not work during the setup of viewer on CI:
This seems unrelated to the PR so I will change this to check for files and settings which should always be around.
There was a problem hiding this comment.
Looks like github sets an environment variable BRANCH that matches the target branch of the PR - but we use it as the server branch for the container.
Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
test/docker-commands
branch
from
22ef885 to
fed018f
Compare
skjnldsv
approved these changes
Jan 8, 2025
max-nextcloud
added a commit
that referenced
this pull request
Jan 8, 2025
BRANCH is main in PRs against a main branch for example in apps that use that naming scheme and in `@nextcloud/cypress` itself. See #731 (review)
max-nextcloud
force-pushed
the
test/docker-commands
branch
from
0047266 to
fed018f
Compare
|
0047266 was an attempt at a fix for the branch issue - but that should be discussed separately. So reverting this to the approved state to then merge ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.