Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazy load nodemailer #3168

Closed
wants to merge 1 commit into from
Closed

lazy load nodemailer #3168

wants to merge 1 commit into from

Conversation

anguskeatinge
Copy link

lazy load nodemailer

@github-actions github-actions bot added core Refers to `@auth/core` providers labels Nov 10, 2021
@anguskeatinge anguskeatinge mentioned this pull request Nov 10, 2021
Closed
@balazsorban44
Copy link
Member

You can test it yourself, but this won't actually be tree-shaken. From my experience, when built with next build, nodemailer was still part of the bundle, and I could not even start a server with next dev. This is because (if my understanding is correct), Next.js requires dynamic imports in development even if it's in conditionals.

@anguskeatinge
Copy link
Author

Makes sense - thanks for the detailed explanation!

@balazsorban44 balazsorban44 mentioned this pull request Jul 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Refers to `@auth/core` providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anguskeatinge @balazsorban44