Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: code base improvements 3 #1072

Merged
merged 18 commits into from
Jan 10, 2021
Merged

refactor: code base improvements 3 #1072

merged 18 commits into from
Jan 10, 2021

Commits on Jan 9, 2021

  1. refactor: extend res.{end,send,json}, redirect

    @balazsorban44
    balazsorban44 committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    1dd0562 View commit details
    Browse the repository at this point in the history

  2. refactor: chain res methods, remove unnecessary ones

    @balazsorban44
    balazsorban44 committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    a358fcf View commit details
    Browse the repository at this point in the history

  3. refactor: simplify oauth callback signature

    @balazsorban44
    balazsorban44 committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    5773c09 View commit details
    Browse the repository at this point in the history

  4. refactor: code simplifications

    @balazsorban44
    balazsorban44 committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    6cf1038 View commit details
    Browse the repository at this point in the history

  5. refactor: re-export everything from routes in one

    @balazsorban44
    balazsorban44 committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    8cfc656 View commit details
    Browse the repository at this point in the history

  6. refactor: split up main index.js to multiple files

    @balazsorban44
    balazsorban44 committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    10207b2 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2021

  1. refactor: simplify passing of provider(s) around

    @balazsorban44
    balazsorban44 committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    87e0011 View commit details
    Browse the repository at this point in the history

  2. refactor: extend req with callbackUrl inline

    @balazsorban44
    balazsorban44 committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    3c6f023 View commit details
    Browse the repository at this point in the history

  3. refactor: simplify page rendering

    @balazsorban44
    balazsorban44 committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    c1b3176 View commit details
    Browse the repository at this point in the history

  4. refactor: move error page redirects to main file, simplify renderer

    @balazsorban44
    balazsorban44 committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    98d00de View commit details
    Browse the repository at this point in the history

  5. refactor: inline req.options definition

    @balazsorban44
    balazsorban44 committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    5c4b8d3 View commit details
    Browse the repository at this point in the history

  6. refactor: simplify error fallbacks

    @balazsorban44
    balazsorban44 committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    c86432b View commit details
    Browse the repository at this point in the history

  7. refactor: remove else branches and unnecessary try..catch

    @balazsorban44
    balazsorban44 committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    d6a7f44 View commit details
    Browse the repository at this point in the history

  8. refactor: add docs, and simplify jwt functions

    @balazsorban44
    balazsorban44 committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    75386f3 View commit details
    Browse the repository at this point in the history

  9. refactor: prefer errors object over switch..case in signin page

    @balazsorban44
    balazsorban44 committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    be9f959 View commit details
    Browse the repository at this point in the history

  10. feat: log all params sent to logger instead of only first

    @balazsorban44
    balazsorban44 committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    ac04184 View commit details
    Browse the repository at this point in the history

  11. refactor: fewer lines input validation

    @balazsorban44
    balazsorban44 committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    298dd33 View commit details
    Browse the repository at this point in the history

  12. refactor: remove even more unnecessary else branches

    @balazsorban44
    balazsorban44 committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    332f9fc View commit details
    Browse the repository at this point in the history