Comply with TypeScript strict mode

[balazsorban44]

#2552 introduced TypeScript to the core. A long-time wish from the community, and the maintainers.

For an easier migration, I decided to go with "strict": false, and we still allow ".js" files.

As an improvement, we should make set "strict": true in our tsconfig.json and fix the remaining issues, and convert the rest of the files to TypeScript as well.

[Thisen]

@balazsorban44 Happy to work on it - However I want to split in multiple PRs, so it's smaller changes.

[balazsorban44]

sounds good, I could suggest setting strict: true, but not actually committing it.

[DopamineDriven]

Yes please 🙏

I work with Strict, always strict, and strict null check flags set to true

This would be greatly appreciated

[Thisen]

Working on it. 🙂

[sldavidson]

Anything we can do to get movement on #2802 or #2763?

[balazsorban44]

I pinged the PR creator to fix the conflicts just now #2802 (comment)

[balazsorban44]

#2802 has been merged now, anything left here?

[balazsorban44]

@Thisen, @sldavidson could you test [email protected]?

[copleykj]

@Thisen, @sldavidson could you test [email protected]?

@balazsorban44 so this fixed an issue I was having with the credentials provider throwing a type error for username and password keys, but now it's throwing a type error for the jwt key of the session option.

[copleykj]

[balazsorban44]

that's expected, renamed for clarity
https://next-auth.js.org/getting-started/upgrade-v4#session-strategy

[copleykj]

Oh.. Sorry. This section of the v4 docs had me confused.

[balazsorban44]

Good catch, just updated the docs!

[Thisen]

@Thisen, @sldavidson could you test [email protected]?

It didn't work for me. Also, it looks like the first argument is required for useSession in that version, is that expected?

[balazsorban44]

no it isn't and was supposed to be fixed in 419ffe7

and it looks good still

next-auth/src/react/index.tsx

Line 87 in 35ee608

export function useSession<R extends boolean>(options?: UseSessionOptions<R>) {

line 26: https://unpkg.com/browse/[email protected]/react/index.d.ts

[stale]

Hi there! It looks like this issue hasn't had any activity for a while. It will be closed if no further activity occurs. If you think your issue is still relevant, feel free to comment on it to keep it open. (Read more at #912) Thanks!

[stale]

Hi there! It looks like this issue hasn't had any activity for a while. To keep things tidy, I am going to close this issue for now. If you think your issue is still relevant, just leave a comment and I will reopen it. (Read more at #912) Thanks!

[aspnetde]

#2701 unfortunately is still a thing (but was closed in favor for this one, which then went stale for some reason).

[currenthandle]

#2701 unfortunately is still a thing (but was closed in favor for this one, which then went stale for some reason).

I'm still getting this same issue as well.

[Simvolick]

Really waiting for this because of the VkProvider

[karambir-zz]

I'm having the same problem with #2701

[ondraczsk]

Yes #2701 still an error

[cantutar]

I can confirm that issue is still on.

[saurabhsri108]

The issue still exists. Going with the strict: false for now gives even more errors.

[nos-nart]

I encounter the same error, turn off the strict mode in tsconfig.json still shows type error, I ignore it temporarily.

[coycoylaniba]

does anyone have a fix for this? im also getting this error.

[Zarathos1084]

Still getting the same error as well, is there a way we can reopen this?

[sumanchapai]

This fixes issues for me in the authorize function with strict typescript mode.

import { API_LOGIN } from "lib/apis"
import NextAuth from "next-auth"
import CredentialsProvider from "next-auth/providers/credentials"

export default NextAuth({
    providers: [
        CredentialsProvider({
            type: 'credentials',
            credentials: {},
            async authorize(credentials: Record<string, string> | undefined, req) {
                const authResponse = await fetch(API_LOGIN, {
                    method: "POST",
                    headers: {
                        "Content-Type": "application/json",
                    },
                    body: JSON.stringify(credentials),
                })

                if (!authResponse.ok) {
                    return null
                }

                const user = await authResponse.json()

                return user
            },
        }),
    ],
})

Note that

import { API_LOGIN } from "lib/apis"

line is custom to your project!