Step1: 장바구니 목록 구성 #48
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package nextstep.shoppingcart.data.model | ||
|
|
||
| data class Product( | ||
| val imageUrl: String = "https://picsum.photos/500", | ||
| val name: String, | ||
| val price: Int, | ||
| val description: String | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| package nextstep.shoppingcart.ui.component | ||
|
|
||
| import android.util.Log | ||
| import androidx.compose.foundation.background | ||
| import androidx.compose.foundation.isSystemInDarkTheme | ||
| import androidx.compose.foundation.layout.Column | ||
| import androidx.compose.foundation.layout.fillMaxWidth | ||
| import androidx.compose.foundation.layout.height | ||
| import androidx.compose.foundation.layout.padding | ||
| import androidx.compose.foundation.layout.wrapContentHeight | ||
| import androidx.compose.material3.Surface | ||
| import androidx.compose.material3.Text | ||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.ui.Alignment | ||
| import androidx.compose.ui.Modifier | ||
| import androidx.compose.ui.graphics.Color | ||
| import androidx.compose.ui.layout.ContentScale | ||
| import androidx.compose.ui.platform.LocalContext | ||
| import androidx.compose.ui.res.stringResource | ||
| import androidx.compose.ui.text.font.FontWeight | ||
| import androidx.compose.ui.text.style.TextOverflow | ||
| import androidx.compose.ui.tooling.preview.Preview | ||
| import androidx.compose.ui.unit.dp | ||
| import coil.ImageLoader | ||
| import coil.compose.AsyncImage | ||
| import coil.compose.AsyncImagePainter | ||
| import com.bumptech.glide.integration.compose.ExperimentalGlideComposeApi | ||
| import nextstep.shoppingcart.R | ||
| import nextstep.shoppingcart.data.model.Product | ||
| import nextstep.shoppingcart.ui.theme.getColorScheme | ||
| import okhttp3.OkHttpClient | ||
| import java.security.SecureRandom | ||
| import java.security.cert.X509Certificate | ||
| import javax.net.ssl.SSLContext | ||
| import javax.net.ssl.TrustManager | ||
| import javax.net.ssl.X509TrustManager | ||
|
|
||
| @OptIn(ExperimentalGlideComposeApi::class) | ||
| @Composable | ||
| fun ShoppingItemView(product: Product) { | ||
|
There was a problem hiding this comment. 기존 XML 기반에 View 와는 구분하기위해, 컴포즈에선 보통 ~View라고 네이밍 짓지 않고 있어요 |
||
| val colorScheme = getColorScheme() | ||
|
|
||
| val trustAllCerts = arrayOf<TrustManager>(object : X509TrustManager { | ||
| override fun checkClientTrusted(chain: Array<out X509Certificate>?, authType: String?) {} | ||
| override fun checkServerTrusted(chain: Array<out X509Certificate>?, authType: String?) {} | ||
| override fun getAcceptedIssuers(): Array<X509Certificate> = arrayOf() | ||
| }) | ||
|
|
||
| val sslContext = SSLContext.getInstance("SSL").apply { | ||
| init(null, trustAllCerts, SecureRandom()) | ||
| } | ||
|
|
||
| val okHttpClient = OkHttpClient.Builder() | ||
| .sslSocketFactory(sslContext.socketFactory, trustAllCerts[0] as X509TrustManager) | ||
| .hostnameVerifier { _, _ -> true } | ||
| .build() | ||
|
Comment on lines
+43
to
+56
There was a problem hiding this comment. ssl 관련 설정을 하신 이유가 있나요? |
||
|
|
||
| val imageLoader = ImageLoader.Builder(LocalContext.current) | ||
| .okHttpClient { okHttpClient } | ||
| .build() | ||
|
|
||
| Column( | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .wrapContentHeight() | ||
| .padding(5.dp) | ||
| .background(colorScheme.background), | ||
|
Comment on lines
+63
to
+67
There was a problem hiding this comment. ShoppingItemView에 Modifier를 파라미터로 넘겨주는것과 |
||
| horizontalAlignment = Alignment.CenterHorizontally | ||
| ) { | ||
| AsyncImage( | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .height(158.dp), | ||
| contentScale = ContentScale.Crop, | ||
| model = product.imageUrl, | ||
| contentDescription = null, | ||
| imageLoader = imageLoader, | ||
| onState = { state -> | ||
| when (state) { | ||
|
Comment on lines
+78
to
+79
There was a problem hiding this comment. onState를 사용하신 이유가 있을까요? |
||
| is AsyncImagePainter.State.Loading -> { | ||
|
|
||
| } | ||
|
|
||
| is AsyncImagePainter.State.Success -> { | ||
|
|
||
| } | ||
|
|
||
| is AsyncImagePainter.State.Error -> { | ||
| Log.d("irondler", "Error = ${state.result.throwable.message}") | ||
| } | ||
|
|
||
| else -> { | ||
|
|
||
| } | ||
| } | ||
| } | ||
| ) | ||
| Text( | ||
| text = product.name, | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .padding(horizontal = 2.dp), | ||
| maxLines = 1, | ||
| softWrap = true, | ||
| fontWeight = FontWeight.Bold, | ||
| overflow = TextOverflow.Ellipsis, | ||
| color = if(isSystemInDarkTheme()) Color.White else Color.Black | ||
| ) | ||
| Text( | ||
| text = stringResource(id = R.string.product_price, product.price), | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .padding(horizontal = 2.dp), | ||
| maxLines = 1, | ||
| softWrap = true, | ||
| overflow = TextOverflow.Ellipsis, | ||
| color = if(isSystemInDarkTheme()) Color.White else Color.Black | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| @Preview | ||
| @Composable | ||
| fun ShoppingItemViewPreview() { | ||
| Surface { | ||
| ShoppingItemView(Product(name = "name", price = 9999, description = "description")) | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| <resources> | ||
| <string name="app_name">Shopping Cart</string> | ||
| <string name="product_list">상품 목록</string> | ||
| <string name="product_price">%1d원</string> | ||
| </resources> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glide compose는 아직 beta이군요, 평소에도 glide compose를 활용하시는 편이신가요?
그러나, 이번 과제에서는 glide를 사용하지 않는거 같아요 :)
지워주셔도 좋을거같네요!