Automatically clear transient upon settings change #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in OrderLimiterTest::count_qualifying_orders_should_not_limit_results() Instead of using the WP default of 10 and generating 24 orders (which takes some time), lower the default setting to 2, then generate 5 orders. Locally, this has sped up test suite execution by ~10s.
…laced within the current interval, as changing the settings will cause those to be recalculated
stevegrunwell
added
documentation
bswatson
approved these changes
Jun 26, 2020
This was referenced Jul 15, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces logic to automatically delete the "limit_orders_order_count" transient any time the "limit_orders" option changes.
Additionally, if a store owner visits the settings screen while there's at least one order within the current interval, they will be warned that the order limiting will be recalculated using the new values.
Finally, the PR refactors the test suite a bit so we have a base
TestCaseclass, giving us the ability to generate dummy orders from any test method.Fixes #36.