Prevent showing our customer notices in WP Admin #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[As WordPress.org user dennisdbn noticed](https://wordpress.org/support/topic/php-call-to-undefined-function), the customer-facing notice was _attempting_ to display on the WooCommerce products page. Unfortunately, this is a) unnecessary and b) difficult, considering the wc-notice-functions.php file is only loaded on front-end pages of a WooCommerce site. This commit adds a quick `is_admin()` check, ensuring we abort early from `OrderLimiter::customer_notice()` if we're in WP Admin.
bswatson
approved these changes
Apr 16, 2020
The WordPress core test suite still doesn't support PHPUnit 8 and PHPUnit 7.x won't run on PHP 7.0, so we'll use PHPUnit 6 when testing the ancient version(s) of PHP but default to 7.x
bswatson
approved these changes
Apr 16, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As WordPress.org user dennisdbn noticed, the customer-facing notice was attempting to display on the WooCommerce products page.
Unfortunately, this is a) unnecessary and b) difficult, considering the wc-notice-functions.php file is only loaded on front-end pages of a WooCommerce site.
This PR adds a quick
is_admin()check, ensuring we abort early fromOrderLimiter::customer_notice()if we're in WP Admin.