-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theia devel 1.40 update #13
Conversation
Thanks @MarkFitzpatrickNN, looking at this now. |
Your branch has a seemingly empty merge commit that I prefer to keep out of I've therefore cherry-picked ec97b3e into the Next I've tested build for other supported architectures as per https://github.com/newsnowlabs/dockside/blob/main/docs/developing/building-production-image.md with the following results:
The
|
I've tried numerous modifications to the Theia build command line - increasing I've tried these options on Depot's arm hardware with 32GB RAM, so it is hard to see why memory shortage should be an issue. I've reluctantly concluded that Theia 1.40.0 is incompatible with the This presented a conundrum:
(1) is not an option. I am reluctant to accept (2) right now, as while there is now a 64bit version of Raspbian able to run on rPi 4, it is still relatively new and seems a shame to drop support when Dockside still works. And it is not inconceivable that this issue will arise again, with a new version of Theia working on some supported platforms but not yet on others. I have therefore opted to modify the build process to support different Theia versions for different platforms. Docker does not support setting build variables to different values for different platforms. This therefore entailed moving the Theia version specification from I am pushing the changes from your branch to a new branch https://github.com/newsnowlabs/dockside/tree/theia-devel-1.40-mixed. (Please note the |
I am closing this PR having created a new one (#14) from the new branch. Please review the changes and comment there. |
Thanks Struan, I've made some notes on these smaller things that caught me out for future reference. |
Update theia from version 1.35.0 to version 1.40.0.