Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Updated the event types and added some attributes and mobile endpoint for VideoAction #83

Merged
merged 49 commits into from
Feb 24, 2025
Merged

feat: Updated the event types and added some attributes and mobile endpoint for VideoAction #83

merged 49 commits into from
Feb 24, 2025
+806 −478

Conversation

bmendiratta137
Copy link
Collaborator

  • RokuSystem renamed to ConnectedDeviceSystem
  • RokuVideo renamed to VideoAction
  • Introduced new event types VideoErrorAction for errors, VideoAdAction for ads and VideoCustomAction for custom events
  • VideoAction data will be passed to mobile endpoint
  • Added some attributes like enduser.id, elapsedTime and bufferType etc

bmendiratta137 and others added 30 commits November 28, 2024 15:00
@bmendiratta137
divided rokuVideo to videoAction and videoAdAction and rokuSystem to …
de8e9cb 
…videoCustomAction and introduced videoErrorAction
@bmendiratta137
replaced videoCustomAction with RokuSystem and added a function for v…
ef416c4 
…ideoCustomAction
@bmendiratta137
updated videoCustomAction function
f2cb932
@bmendiratta137
added a condition for videoCustomAction
a1fb67c
@bmendiratta137
switching attributes
30d6389
@bmendiratta137
minor fix
6baf594
@bmendiratta137
revert some changes for testing
63d64ad
@bmendiratta137
minor fix
3e200fb
@bmendiratta137
adding capability of setting user id
c900a00
@bmendiratta137
renamed userId to enduser.id
9dd805a
@bmendiratta137
updated readme.md
c1af25e
@bmendiratta137
update datamodel.md
4586d3d
@bmendiratta137
adding userId in readme.md
cf08555
@bmendiratta137
minor fix
479d77e
@bmendiratta137
update datamodel.md
6e5eb13
@bmendiratta137
minor fix
3af34aa
@avinash-newrelic
Merge pull request #78 from bmendiratta137/nr-339475-standardising-ev…
ba2e98e 
…ent-type-in-roku-agent

feat: Merge all changes to develop branch
@avinash-newrelic
feat: Send video events via mobile endpoint
815358b
@avinash-newrelic
fix: Revert token expose
7b1b62d
@bmendiratta137
added src Roku and some error attributes
73e9a8b
@bmendiratta137
Merge pull request #1 from avinash-newrelic/hit-mobile-endpoint
b1e109a 
feat: Send video events via mobile endpoint
@bmendiratta137
switching timestamp from string to long
9ff9de8
@bmendiratta137
Adding elapsed time logic
0997cea
@bmendiratta137
Pushing all changes to develop branch
36e7065
@bmendiratta137
added appName as parameter
1e592bb
@bmendiratta137
Merge branch 'stable' into develop-changes
e2c2cf6
@bhansa-nr
Merge pull request #79 from bmendiratta137/develop-changes
7f64484 
Pushing all changes to develop branch
@bmendiratta137
Update NRAgent.brs
89b9aed
@bmendiratta137
changed RokuSystem to ConnectedDeviceSystem
844c189
@bmendiratta137
Merge branch 'develop' into changing-rokusystem-to-connectDeviceSystem
288fdbe
mlychndnnr
mlychndnnr approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@mlychndnnr mlychndnnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mlychndnnr mlychndnnr merged commit a3eae16 into master Feb 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlychndnnr mlychndnnr mlychndnnr approved these changes

@avinash-newrelic avinash-newrelic avinash-newrelic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmendiratta137 @avinash-newrelic @mlychndnnr @bhansa-nr