fix(nodejs) : Fixed nodejs deployer scripts #1161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nandu-pns
approved these changes
Feb 17, 2025
Nandu-pns
requested changes
Feb 17, 2025
Comment on lines
7
to
18
| # create a sample Dockerfile | ||
| - name: Create a sample Dockerfile | ||
| copy: | ||
| content: | | ||
| FROM node:18 | ||
| WORKDIR /app | ||
| COPY . /app | ||
| RUN npm install | ||
| EXPOSE 3000 | ||
| CMD ["node", "app.js"] | ||
| dest: "/home/{{ ansible_user }}/myNodeApp/Dockerfile" | ||
| mode: "0644" |
There was a problem hiding this comment.
The changes look good overall! For better readability, I was wondering if we could exclude the Dockerfile and sample application example changes from main.yml and move them under templates directory, similar to the existing structure for NodeJS?
There was a problem hiding this comment.
Thanks a lot @Nandu-pns the suggested changes are done!!
Nandu-pns
requested changes
Feb 17, 2025
Comment on lines
53
to
71
| - name: Create sample Node.js application | ||
| copy: | ||
| content: | | ||
| const http = require('http'); | ||
|
|
||
| # - name: set node.js version 20.5.1 as default | ||
| # shell: nvm alias default 20.5.1 | ||
| const hostname = '127.0.0.1'; | ||
| const port = 3000; | ||
|
|
||
| # - name: Create node.js app directory | ||
| # file: | ||
| # path: /home/ec2-user/myNodeApp | ||
| # state: directory | ||
| const server = http.createServer((req, res) => { | ||
| res.statusCode = 200; | ||
| res.setHeader('Content-Type', 'text/plain'); | ||
| res.end('Hello, Node.js!\n'); | ||
| }); | ||
|
|
||
| # - name: Copy files to myNodeApp directory | ||
| # synchronize: | ||
| # src: "{{ item }}" | ||
| # dest: /home/ec2-user/myNodeApp | ||
| # mode: push | ||
| # with_fileglob: | ||
| # - "../../../../templates/*" | ||
| # become: true | ||
| server.listen(port, hostname, () => { | ||
| console.log(`Server running at http://${hostname}:${port}/`); | ||
| }); | ||
| dest: "/home/{{ ansible_user }}/myNodeApp/app.js" | ||
| mode: "0644" |
There was a problem hiding this comment.
Same applies here as well.
https://github.com/newrelic/open-install-library/pull/1161/files#r1958171757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the Node.js deployer scripts to support both Docker and Linux on-host installation flows.
Ansible playbook validation
Docker
NodeJs Docker Based Instrumentation:-
Ansible playbbok validation for OnHost
NodeJs OnHost Linux Based Instrumentation:-
More informations can be found in JIRA ticket