Provide improvements to shell script wrapper. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The improvements are centered on error handling. As an operator, I want the script: - to find the java binary from JAVA_HOME by default and then from the path. If it finds the jar in neither place, then output a useful error message - exit with a non-zero code if there are unitialized bash variables - exit with a non-zero code and useful error message if the jar cannot be found
|
Thanks for the useful contribution @jaloren and sorry for the delayed response from our side. |
alejandrodnm
added a commit
that referenced
this pull request
Feb 6, 2019
alejandrodnm
added a commit
that referenced
this pull request
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The improvements are centered on error handling. As an operator, I want
the script:
then from the path. If it finds the jar in neither place, then output a
useful error message
be found