Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quadrupled thrift frame size #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darthskotina
Copy link

Description

What are you changing/fixing?

When attempting to use gojmx to monitor Trino I have stumbled upon the following error:
nrjmx client error: nrjmx process exited with error: exit status 1: stderr: org.apache.thrift.transport.TTransportException: Frame size (9853) larger than max length (8192)! at org.apache.thrift.transport.layered.TFramedTransport.readFrame(TFramedTransport.java:148)\n at org.apache.thrift.transport.layered.TFramedTransport.read(TFramedTransport.java:100)\n at org.apache.thrift.transport.TTransport.readAll(TTransport.java:100)\n at org.apache.thrift.protocol.TCompactProtocol.readByte(TCompactProtocol.java:622)\n at org.apache.thrift.protocol.TCompactProtocol.readMessageBegin(TCompactProtocol.java:479)\n at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:27)\n at org.newrelic.nrjmx.v2.StandardIOServer.listen(StandardIOServer.java:55)\n at org.newrelic.nrjmx.Application.runV2(Application.java:122)\n at org.newrelic.nrjmx.Application.main(Application.java:46)\n

increasing maxLength for TFramedTransport.Factory resolves the issue

Does your Pull Request introduce breaking changes?

no

Do the users need to upgrade immediately to the new version?

no

Do you introduce new dependencies on other libraries?

no

Checklist: before you submit

build.log

  • apply the labels that best suit the context of your Pull Request.
  • include unit or integration testing for your changes/additions.

…ting to monitor Trino lead to stderr: org.apache.thrift.transport.TTransportException: Frame size (9853) larger than max length (8192)
@darthskotina darthskotina requested a review from a team April 29, 2024 17:17
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


[email protected] seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@darthskotina
Copy link
Author

darthskotina commented May 22, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants