Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR-100933 chore: upgrade to Go 1.20 #145

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Conversation

DavSanchez
Copy link
Contributor

Description

What are you changing/fixing?

Describe the intent of your pull request.

Does your Pull Request introduce breaking changes?

Yes/no. If yes: which ones?

Do the users need to upgrade immediately to the new version?

Yes/no. Why?

Do you introduce new dependencies on other libraries?

Yes/no. If yes: which ones?

Checklist: before you submit

  • apply the labels that best suit the context of your Pull Request.
  • include unit or integration testing for your changes/additions.

@DavSanchez DavSanchez force-pushed the NR-100933-bump_to_go_1_20 branch from 99327e5 to dbc9a8d Compare March 24, 2023 15:09
@DavSanchez DavSanchez marked this pull request as ready for review March 24, 2023 15:15
@DavSanchez DavSanchez requested a review from a team March 24, 2023 15:15
Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -22,7 +22,6 @@ env:
AWS_S3_BUCKET_NAME: "nr-downloads-ohai-staging"
AWS_S3_LOCK_BUCKET_NAME: "onhost-ci-lock-staging"
AWS_REGION: "us-east-1"
GO_VERSION: '1.16.10'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@DavSanchez DavSanchez merged commit baf9eca into master Mar 27, 2023
@DavSanchez DavSanchez deleted the NR-100933-bump_to_go_1_20 branch March 27, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants