feat(emitter): add infra sdk emitter #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carlosroman Added you as reviewer to keep you in the loop of what's being changed in POMI. Ofc suggestions welcome |
|
We have a dependency with #64 in order to work best. It might need a rebase/merge after that PR gets merged |
paologallinaharbur
previously approved these changes
Aug 27, 2020
ardias
dismissed stale reviews from paologallinaharbur and gsanchezgavier
via
3c5bd1a
gsanchezgavier
previously approved these changes
Aug 31, 2020
paologallinaharbur
previously approved these changes
Sep 1, 2020
paologallinaharbur
previously approved these changes
Sep 3, 2020
|
There are conflicting files and no test can run, can you fix that? A part from that since last review the only change I see are the updated dependencies and the vendor folder |
The last changes were just updating to the correct infra-sdk version fixing the conflict with main. It's fixed |
paologallinaharbur
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Infra sdk emitter to the list of possible emitters. The Infra SDK emitter will output to stdout the metrics in the new SDK V4 format which is used for dimensional metrics support.