feat(integrationBehaviour): the integration accept a new parameter to…

[paologallinaharbur]

The nri-prometheus integration now accepts new config/parameters:

• StandAlone in the config file permits changing the whole behaviour of the integration
• ConfigPath argument allows to set a new path for the configuration file used by Viper (previously hardcoded). In particular that feature is going to be used by the agent when passing the path to a tmp file generated from the integration config file.

By default the behaviour is the old one, however if standAlone is set to True a new behaviour kicks in.

Moreover the Viper version has been bumped up since the file passed by the agent is extensionless and only a newer version of Viper supports it and go mod tidy has been run

Old behaviour:

• nri-prometheus is capable to run as a standAlone integration, it manages automatically scraping metrics, processing them and sending data to the NewRelic.
  The process does not terminate after sending the data, therefore once defined the targets they get scraped periodically and the result is sent
  Moreover the integration is exposing telemetry data through a prometheus endpoint.

New behaviour

• Currently it is just a stub (printing "New Behaviour" and exiting) in order to allow reviewing the change of the main in an easier way.
  The new behaviour would transform this integration making it more similar to a onHost integration, therefore it will focus merely on scraping data and processing it. The execution and sending the data will be managed by the agent.

  It will output the data on stdOut and exit leveraging the agent to send data and to perform auto-discovery

[CLAassistant]

All committers have signed the CLA.

[alejandrodnm]

Hi @paologallinaharbur can you please explain the old and new behaviours in the PR description and why it's needed

[davidbrota]

I've left some comments.

[davidbrota]

LGTM

[gsanchezgavier]

I think we could remove this and use the default instead. inventory_source is set by default as integration/nri-prometheus . docs .

[jorik]

Do you know why it was set explicitly here, @gsanchezgavier? Removing it here and using the default will change the actual name.

[gsanchezgavier]

no i don't, but inventory is not being used afaik here.

[jorik]

I'm just keeping it like this for now, and discuss this with Paolo when he's back. We'll not do a release with it yet, anyway.

[morecar]

koolio