Don't run snyk on PR builds #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandrodnm
previously approved these changes
Jun 9, 2020
alejandrodnm
reviewed
Jun 9, 2020
.travis.yml
Outdated
| @@ -4,8 +4,8 @@ go: | |||
| - "1.13" | |||
| script: | |||
| - make | |||
| - npm install -g snyk | |||
| - make snyk | |||
| - 'if [ "$TRAVIS_PULL_REQUEST" = "false" ]; then npm install -g snyk; fi' | |||
There was a problem hiding this comment.
can we just better do SNYK_TOKEN != "" that way for PRs from the same repo snyk runs.
There was a problem hiding this comment.
Makes sense. Will change it.
areina
force-pushed
the
disable-snyk-in-pull-requests
branch
from
a393e01 to
87eb9f7
Compare
alejandrodnm
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of this security constraint, we can't execute the
snyk teststep on travis for pull requests.