Upgrade telemetry sdk #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jorik
reviewed
Feb 5, 2020
internal/cmd/scraper/scraper.go
Outdated
|
|
||
| emitter, err := integration.NewTelemetryEmitter(c) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
For debugging it's helpful to annotate the errors, to give a bit of context, e.g.: return errors.Wrap(err, "could not create new TelemetryEmitter)`
jorik
reviewed
Feb 5, 2020
internal/integration/roundtripper.go
Outdated
| @@ -11,7 +11,7 @@ type licenseKeyRoundTripper struct { | |||
| // RoundTrip wraps the `RoundTrip` method removing the "X-Insert-Key" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the old vendored telemetry-sdk and replace it with the current open sourced one.
I also had to do some small changes to the code because some error handling has changed.
Also removed the current NaN code because the telemetry sdk handles it now and fix an issue with headers.