FSI-1155: Don't scrape pods without a valid PodIP #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglascamata
changed the title
jorik
force-pushed
the
feature/dont-scrape-pods-without-ip
branch
3 times, most recently
from
3c81055 to
9c254dc
Compare
jorik
force-pushed
the
feature/dont-scrape-pods-without-ip
branch
from
d21c5a2 to
b847efa
Compare
alejandrodnm
approved these changes
Oct 22, 2019
alejandrodnm
suggested changes
Oct 24, 2019
added 7 commits
October 24, 2019 11:21
…and caches them, which makes them unscrabable unless you restart POMI. This includes a simple program that runs the KubernetesTargetRetriever locally so you can debug it locally.
jorik
force-pushed
the
feature/dont-scrape-pods-without-ip
branch
from
b847efa to
613f42c
Compare
|
@alejandrodnm done! |
alejandrodnm
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug that adds newly created Pod-targets without an ipAddress and caches them, which makes them unscrabable unless you restart POMI.
It also includes a simple program that runs the KubernetesTargetRetriever locally so you can debug it.