remove provider prefix

newrelic · Sep 2, 2020 · 5e8aae9 · 5e8aae9
1 parent 5ea583c
commit 5e8aae9
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 10 deletions.
diff --git a/internal/integration/spec.go b/internal/integration/spec.go
@@ -24,7 +24,6 @@ type Specs struct {
 
 // SpecDef contains the rules to group metrics into entities
 type SpecDef struct {
-	Provider string      `yaml:"provider"`
 	Service  string      `yaml:"service"`
 	Entities []EntityDef `yaml:"entities"`
 }
@@ -98,7 +97,7 @@ func (s *Specs) getEntity(m Metric) (entityName string, entityType string, err e
 		return "", "", fmt.Errorf("metric: %s is not defined in service:%s", m.name, spec.Service)
 	}
 
-	entityType = strings.Title(spec.Provider) + strings.Title(spec.Service) + strings.Title(e.Type)
+	entityType = strings.Title(spec.Service) + strings.Title(e.Type)
 
 	entityName = e.Type
 

diff --git a/internal/integration/spec_test.go b/internal/integration/spec_test.go
@@ -52,7 +52,7 @@ func TestSpecs_getEntity(t *testing.T) {
 					},
 				}},
 			wantEntityName: "database:test",
-			wantEntityType: "PrometheusRavendbDatabase",
+			wantEntityType: "RavendbDatabase",
 			wantErr:        false,
 		},
 		{
@@ -64,7 +64,7 @@ func TestSpecs_getEntity(t *testing.T) {
 					attributes: labels.Set{},
 				}},
 			wantEntityName: "node",
-			wantEntityType: "PrometheusRavendbNode",
+			wantEntityType: "RavendbNode",
 			wantErr:        false,
 		},
 		{
@@ -79,7 +79,7 @@ func TestSpecs_getEntity(t *testing.T) {
 					},
 				}},
 			wantEntityName: "testentity:first:second",
-			wantEntityType: "PrometheusRavendbTestentity",
+			wantEntityType: "RavendbTestentity",
 			wantErr:        false,
 		},
 		{
@@ -91,7 +91,7 @@ func TestSpecs_getEntity(t *testing.T) {
 					attributes: labels.Set{},
 				}},
 			wantEntityName: "instance",
-			wantEntityType: "PrometheusRedisInstance",
+			wantEntityType: "RedisInstance",
 			wantErr:        false,
 		},
 		{
@@ -103,7 +103,7 @@ func TestSpecs_getEntity(t *testing.T) {
 					attributes: labels.Set{},
 				}},
 			wantEntityName: "instance",
-			wantEntityType: "PrometheusRedisInstance",
+			wantEntityType: "RedisInstance",
 			wantErr:        false,
 		},
 		{

diff --git a/internal/integration/test/prometheus_ibmmq.yaml b/internal/integration/test/prometheus_ibmmq.yaml
@@ -1,4 +1,3 @@
-provider: prometheus
 service: ibmmq
 display_name: IBM MQ
 entities:

diff --git a/internal/integration/test/prometheus_ravendb.yml b/internal/integration/test/prometheus_ravendb.yml
@@ -1,4 +1,3 @@
-provider: prometheus
 service: ravendb
 display_name: Raven Db
 entities:

diff --git a/internal/integration/test/prometheus_redis.yml b/internal/integration/test/prometheus_redis.yml
@@ -1,4 +1,3 @@
-provider: prometheus
 service: redis
 display_name: Redis
 entities: