-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autodetect consumer producer names #178
Conversation
86c12d2
to
3bd6cca
Compare
e032b7e
to
1e89e11
Compare
803d23b
to
bd0b261
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, like this we are behaving like we used to and making the fallback to app-info
Closes #159
This PR introduces support to detect automatically consumer/producer
client.id
. As agreed in this internal link, we made thename
field optional for consumers and producers and introduced thedefault
alias, so: