revert pr 429 #432
Merged
revert pr 429 #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR temporary reverts #429
We faced issues while running nri-flex on some environments because of dependency on glibc
This happens when using cgo (e.g. github.com/mattn/go-sqlite3)
Will revert this change until we find a fix
./nri-flex: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by ./nri-flex)
linux-vdso.so.1 (0x00007fff69b98000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f296dd88000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f296db69000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f296d778000)
/lib64/ld-linux-x86-64.so.2 (0x00007f296df8c000)
symbol fcntl64 version GLIBC_2.28 not defined in file libc.so.6 with link time reference (./nri-flex)
Trying to compile it without gcc points to the library using it:
github.com/mattn/go-sqlite3
cgo: C compiler "gcc" not found: exec: "gcc": executable file not found in $PATH