Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump go to 1.20 (NEWRELIC-8471) #147

Merged
merged 4 commits into from
Jun 2, 2023
Merged

bump go to 1.20 (NEWRELIC-8471) #147

merged 4 commits into from
Jun 2, 2023

Conversation

gsanchezgavier
Copy link
Contributor

  • Bumps Go version to 1.20

@gsanchezgavier gsanchezgavier requested a review from a team June 2, 2023 08:21
@gsanchezgavier gsanchezgavier changed the title bump go to 1.20 bump go to 1.20 (NEWRELIC-8471) Jun 2, 2023
sigilioso
sigilioso approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@sigilioso sigilioso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I left a suggestion that can be addressed now or later, your choice 😉

.github/workflows/push_pr.yml Outdated
@@ -12,7 +12,7 @@ env:
REPO_FULL_NAME: ${{ github.event.repository.full_name }}
INTEGRATION: elasticsearch
ORIGINAL_REPO_NAME: "newrelic/nri-elasticsearch"
GO_VERSION: '1.18'
GO_VERSION: '1.20'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we consider using the go.mod file approach?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes good idea, is a good opportunity

@gsanchezgavier gsanchezgavier merged commit 25ae1d1 into master Jun 2, 2023
@gsanchezgavier gsanchezgavier deleted the bump-deps branch June 2, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigilioso sigilioso sigilioso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsanchezgavier @sigilioso