use centralized builder image #264
Merged
+20
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makefile
Outdated
| GO_VERSION ?= $(shell grep '^go ' go.mod | awk '{print $$2}') | ||
| UBUNTU_VERSION ?= "16.04" | ||
| BUILDER_IMAGE_TAG ?= "latest" | ||
| BUILDER_IMAGE ?= "ghcr.io/newrelic/coreint-automation:latest-go$(GO_VERSION)-ubuntu$(UBUNTU_VERSION)" |
There was a problem hiding this comment.
Oh I think I misunderstood how we were using it, so we leverage pre-compiled images, we do not trigger the creation each time
There was a problem hiding this comment.
Yes, we only trigger when we want a new image built for a new version, OR if some changes are pushed to main.
paologallinaharbur
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the centralized docker image for building.
How is it tested?
Created a pre-release and the action trigged successfully to build and push the artifacts to s3 in the correct location.
https://github.com/newrelic/nri-docker/actions/runs/11907011686