Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI often fails with linter timing out #38

Closed
invidian opened this issue Jun 2, 2021 · 0 comments · Fixed by #46
Closed

CI often fails with linter timing out #38

invidian opened this issue Jun 2, 2021 · 0 comments · Fixed by #46
Labels
bug Categorizes issue or PR as related to a bug. test Categorizes issue or PR as related to a consistently or frequently failing test.

Comments

@invidian
Copy link
Contributor

invidian commented Jun 2, 2021

E.g. https://github.com/newrelic/nri-discovery-kubernetes/runs/2730355852?check_suite_focus=true
@invidian invidian added bug Categorizes issue or PR as related to a bug. test Categorizes issue or PR as related to a consistently or frequently failing test. labels Jun 2, 2021
invidian added a commit that referenced this issue Aug 11, 2021
@invidian
.golangci.yml: increase timeout
4ea5ab0 
Closes #38

Signed-off-by: Mateusz Gozdek <[email protected]>
@invidian invidian mentioned this issue Aug 26, 2021
Merged
invidian added a commit that referenced this issue Aug 30, 2021
@invidian
.golangci.yml: increase timeout
1eb6e71 
Closes #38

Signed-off-by: Mateusz Gozdek <[email protected]>
invidian added a commit that referenced this issue Sep 2, 2021
@invidian
Improvements and Kubernetes v1.22 support (#46)
acfc9ae 
* Make golangci.yml effective again

Signed-off-by: Mateusz Gozdek <[email protected]>

* internal/utils: remove dead code

Signed-off-by: Mateusz Gozdek <[email protected]>

* internal: fix found linter warnings

After making linter configuration effective, linter popped up new
issues. This commit addresses them in a minimal way.

Signed-off-by: Mateusz Gozdek <[email protected]>

* Hide goreleaser.yml file

As usually it is hidden.

Signed-off-by: Mateusz Gozdek <[email protected]>

* Update Go Kubernetes modules to v1.22.0

As part of #45

Signed-off-by: Mateusz Gozdek <[email protected]>

* go.mod: update viper to latest version

Signed-off-by: Mateusz Gozdek <[email protected]>

* go.mod: update nri-kubernetes to latest version

Signed-off-by: Mateusz Gozdek <[email protected]>

* .github/workflows/push_pr.yml: fix link to Kubernetes releases

Previous link now redirects to new link and old link will be not
available by the end of this year.

Signed-off-by: Mateusz Gozdek <[email protected]>

* deploy: make manifests compatible with Kubernetes v1.22+

As part of #45.

Signed-off-by: Mateusz Gozdek <[email protected]>

* .github/workflows/push_pr.yml: test against Kubernetes v1.22.X

Closes #45

Signed-off-by: Mateusz Gozdek <[email protected]>

* .golangci.yml: increase timeout

Closes #38

Signed-off-by: Mateusz Gozdek <[email protected]>

* go.mod: force-update github.com/pkg/sftp to latest version

To fix snyk security scan. Upstream update is pending here:
spf13/afero#312

Signed-off-by: Mateusz Gozdek <[email protected]>

* .github/workflows/push_pr.yml: drop support for Kubernetes v1.15

Signed-off-by: Mateusz Gozdek <[email protected]>

* .github/workflows/push_pr.yml: bump patch versions for Kubernetes

Signed-off-by: Mateusz Gozdek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Categorizes issue or PR as related to a bug. test Categorizes issue or PR as related to a consistently or frequently failing test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improvements and Kubernetes v1.22 support newrelic/nri-discovery-kubernetes
1 participant
@invidian