Repository navigation
chore: Fixes issues in CI - #4285
Merged
Merged
Conversation
Node 26.9.0 re-implemented fs.writeFile to open, write, and close in a single native thread-pool job (WriteFileJob) when flush is false, rather than calling the JS-level fs.open the agent instruments. As a result writeFile no longer produces a nested open segment or metric. Branched the writeFile test on the Node version so it expects no open child (and one fewer assertion) on >=26.9.0 while keeping the prior expectation on older runtimes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jsumners-nr
added
dev:tests
jsumners-nr
marked this pull request as ready for review
September 18, 2026 19:07
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4285 +/- ##
==========================================
- Coverage 97.56% 97.48% -0.08%
==========================================
Files 529 529
Lines 63749 63749
Branches 1 1
==========================================
- Hits 62196 62145 -51
- Misses 1553 1604 +51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bizob2828
approved these changes
Sep 21, 2026
| assert.deepEqual(attributes, expected) | ||
| }) | ||
|
|
||
| test('addAttributes() should drop all invalid values', () => { |
Contributor
Author
There was a problem hiding this comment.
Because it already exists on line 59.
github-project-automation
Bot
moved this from Needs PR Review
to Done: Issues recently completed
in Node.js Engineering Board
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks some CI fixes out of #4284.
fsthat made one of our tests sad: fs: write files in one thread pool round trip nodejs/node#65489