test: Fixed flakey when versioned test
#2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This didn't fix the issue. In fact made it more confusing. I'll look more next week |
bizob2828
changed the title
when versioned test
jsumners-nr
approved these changes
Dec 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2821 +/- ##
===========================================
+ Coverage 79.15% 97.13% +17.97%
===========================================
Files 284 294 +10
Lines 45236 46403 +1167
===========================================
+ Hits 35808 45074 +9266
+ Misses 9428 1329 -8099
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This test is failing because it was asserting i took longer than the timeout but less than the delay. I have found in CI sometimes it's taking longer than the delay however, if it'd resolve the delay the test would fail so I'm removing the assertion to assert it takes less than the delay
Related Links
Closes #2826