Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Restricted mysql2 version to get CI working #2808

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

jsumners-nr
Copy link
Contributor

A temporary patch to get our CI working while we investigate why [email protected] is causing our mysql2 promise instrumentation to fail.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.15%. Comparing base (83fd7ee) to head (dc6a37b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2808      +/-   ##
==========================================
- Coverage   97.20%   97.15%   -0.05%     
==========================================
  Files         294      294              
  Lines       46315    46315              
==========================================
- Hits        45021    44999      -22     
- Misses       1294     1316      +22     
Flag Coverage Δ
integration-tests-cjs-18.x 73.37% <ø> (-0.01%) ⬇️
integration-tests-cjs-20.x 73.38% <ø> (-0.01%) ⬇️
integration-tests-cjs-22.x 73.42% <ø> (-0.01%) ⬇️
unit-tests-18.x 88.99% <ø> (ø)
unit-tests-20.x 88.99% <ø> (ø)
unit-tests-22.x 89.00% <ø> (ø)
versioned-tests-18.x 78.99% <ø> (-0.20%) ⬇️
versioned-tests-20.x 78.99% <ø> (-0.20%) ⬇️
versioned-tests-22.x 79.00% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsumners-nr jsumners-nr merged commit ad60ed4 into newrelic:main Dec 2, 2024
29 of 30 checks passed
@jsumners-nr jsumners-nr deleted the mysql2-ci-pass branch December 2, 2024 14:03
@bizob2828 bizob2828 added the dev:tests Indicates only changes to tests label Dec 2, 2024
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

2 participants