-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Instrument tedious MSSQL driver #277
Conversation
@alexashley First and formost -- thank you! This looks like a great start at getting tedious instrumented. Thank you for sharing it! Second, (after a bit of discussion with the team and some other stakeholders), we're trying to move away from including every single DB package possible in the agent. There's lot of complicated reasons for this (some technical, some long-term-support, some "other"), but we're not sure we'd be able to accept your awesome instrumentation into the agent as a first party thing right now. So -- next steps?
That should make it available to folks who want to use it without all the red-tape of getting it into the agent proper. I'm going to close this PR for now, but if you've got any questions about |
@astormnewrelic I can definitely understand how it could be a maintenance burden to instrument a number of 3rd party packages. If the future direction of the agent is individual module instrumentations, would it be possible to create a separate package for some of the integration test utilities (ex: |
…c#277) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…c#277) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR uses the
DatastoreShim
API to instrument the Node.js MSSQL drivertedious
.As a reference, I used this closed PR #211 along with
tedious-newrelic
.It includes integration tests for
select
,insert
,update
, anddelete
, using the MSSQL Linux Docker image.I opened the PR as WIP in order to get feedback on the implementation and tests before adding the following:
NOTES