fix: Improved AWS Lambda event detection #2496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
commented
Aug 20, 2024
| ) { | ||
| result = true | ||
| } | ||
| const v1Keys = [ |
There was a problem hiding this comment.
I can't find any information on what AWS does when some field from this list is not included in the payload. Does it send with field: null? Or does it completely omit the field. We are assuming that it sends field: null with this implementation, because the v1 example shows some such fields.
|
|
||
| // Event used when one Lambda directly invokes another Lambda. | ||
| // https://docs.aws.amazon.com/lambda/latest/dg/invocation-async-retain-records.html#invocation-async-destinations | ||
| const lambaV1InvocationEvent = { |
There was a problem hiding this comment.
I'm not completely convinced this is the only payload shape that Lambda sends with direct invocations. But I can't find any other documentation to prove that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2489.