Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrated superagent instrumentation into agent and no longer bundle @newrelic/superagent #2141

Merged
merged 158 commits into from
Apr 15, 2024

Conversation

jsumners-nr
Copy link
Contributor

This PR resolves #2128.

@CLAassistant
Copy link

CLAassistant commented Apr 11, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.25%. Comparing base (3883348) to head (1a381de).

❗ Current head 1a381de differs from pull request most recent head fde7618. Consider uploading reports for the commit fde7618 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2141   +/-   ##
=======================================
  Coverage   97.24%   97.25%           
=======================================
  Files         250      253    +3     
  Lines       42268    42360   +92     
=======================================
+ Hits        41105    41197   +92     
  Misses       1163     1163           
Flag Coverage Δ
integration-tests-16.x 78.45% <50.45%> (-0.10%) ⬇️
integration-tests-18.x 78.45% <50.45%> (-0.09%) ⬇️
integration-tests-20.x 78.45% <50.45%> (-0.08%) ⬇️
unit-tests-16.x 90.35% <59.63%> (-0.09%) ⬇️
unit-tests-18.x 90.26% <59.63%> (-0.09%) ⬇️
unit-tests-20.x 90.26% <59.63%> (-0.09%) ⬇️
versioned-tests-16.x 74.77% <97.24%> (+0.05%) ⬆️
versioned-tests-18.x 75.87% <97.24%> (+0.05%) ⬆️
versioned-tests-20.x 75.88% <97.24%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsumners-nr jsumners-nr marked this pull request as ready for review April 11, 2024 20:12
@bizob2828 bizob2828 self-assigned this Apr 12, 2024
Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things, but overall looking good.

You'll need to remove superagent from external repos

we will probably have to have a separate story to archive the old repo and deprecate @newrelic/superagent

lib/instrumentation/superagent/nr-hooks.js Outdated Show resolved Hide resolved
lib/instrumentation/superagent/lib/http-methods.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@bizob2828 bizob2828 changed the title chore: Migrated superagent instrumentation into core module refactor: Migrated superagent instrumentation into agent and no longer bundle @newrelic/superagent Apr 12, 2024
@jsumners-nr jsumners-nr force-pushed the issue-2128 branch 2 times, most recently from 3c22991 to 895674a Compare April 15, 2024 13:32
mrickard and others added 19 commits April 15, 2024 11:16
Bumps  and [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse). These dependencies needed to be updated together.

Updates `@babel/traverse` from 7.17.3 to 7.23.2
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

Updates `@babel/traverse` from 7.20.5 to 7.23.2
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [axios](https://github.com/axios/axios) to 1.6.0 and updates ancestor dependency [newrelic](https://github.com/newrelic/node-newrelic). These dependencies need to be updated together.


Updates `axios` from 0.21.4 to 1.6.0
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v0.21.4...v1.6.0)

Updates `newrelic` from 11.0.0 to 11.5.0
- [Release notes](https://github.com/newrelic/node-newrelic/releases)
- [Changelog](https://github.com/newrelic/node-newrelic/blob/main/changelog.json)
- [Commits](newrelic/node-newrelic@v11.0.0...v11.5.0)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: indirect
- dependency-name: newrelic
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.3 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.3...v1.15.4)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Migrate @newrelic/superagent into repo