refactor(mongodb): Removed instrumentation that handles connecting via unix domain socket. #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a unix domain socket.
bizob2828
force-pushed
the
mongo-integration-tests
branch
from
3821706
to
6f3e5b0
Compare
jsumners-nr
approved these changes
Apr 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2129 +/- ##
==========================================
+ Coverage 97.20% 97.24% +0.04%
==========================================
Files 251 250 -1
Lines 42317 42268 -49
==========================================
- Hits 41133 41105 -28
+ Misses 1184 1163 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mongodb instrumentation has business logic to handle when connecting via a unix domain socket and assign that as the port in db instance metrics. It also hard codes the host to
localhost. It is very hard for us to test this in a CI environment as it requires to install a local hosted mongo db server. Due to that and the liklihood of customers connecting via unix domain sockets and 0 bugs reported for this, we are removing this logic.How to Test
Related Issues
Closes #864